Show an error when trying to use unsupported baudrate #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen trying to use unsupported baudrate
KrystianD
changed the title
|
Thanks for PRs! |
|
Also please note ad58141. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had bad times trying to figure out why baudrate I use (500000) is not working with my device while it was working well with other modbus clients. With use of logic analyzer, it turned out mbusd used the default baudrate as 500000 was not supported. I think it would be worth to report an error to the user that he selected (via
-s) an unsupported baudrate rather than silently revert to the default one (19200).0in ttyspeed is now treated as a marker of default baudrate which is then replaced with the default baudrate intty_transpeedfunction.defaultclause just reports an error that unsupported baudrate was selected.