-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for GCC <= 4.9 before compiling #14
Comments
Original comment by Bjoern Forsberg (Bitbucket: bforsbe, GitHub: bforsbe): I agree this would be ideal. However, the supported version of compiler (especially for GCC) depends not only on your CUDA-version but also on you OS. We should put in a warning about using GCC versions higher than 4.x, but for now I think the user should be able to use the CUDA-toolkit documentation about supported compilers to figure out what is needed. But we could definitely include this table in the manual or on the RELION wiki, so that this information is easily accessible when following installation instructions. |
Original comment by Jon Diprose (Bitbucket: well-jon, GitHub: Unknown): I'd rather the restriction only applied for CUDA-enabled builds. Not that I'm using a gcc5 but still, if it's a CUDA-imposed limit the check should only be made if CUDA is being used. Unless other things have problems with gcc5! |
Original comment by Erik Lindahl (Bitbucket: eriklindahl, GitHub: eriklindahl): The problem is that CUDA evolves rapidly, and if we add a warning e.g. for gcc-5.0 that is going to be invalid already within weeks when NVIDIA releases CUDA-8.0. We should thus not warn about specific compiler versions, but the one thing we could do is to try and compile a trivial CUDA program to make sure that works with the selected compiler and CUDA version. |
Original comment by cameron kennedy (Bitbucket: cdk, GitHub: cdk): We seen this failure on our newer boxes, and machines with updated gcc. #if GNUC > 4 || (GNUC == 4 && GNUC_MINOR > 9) // #error -- unsupported GNU version! gcc versions later than 4.9 are not supported! #endif /* GNUC > 4 || (GNUC == 4 && GNUC_MINOR > 9) */ |
optimal motion parameters are now written to <out>/opt_params.txt and can be used by motion_refine with the --params_file argument (overrides cmd. line arguments)
Originally reported by: Dimitry Tegunov (Bitbucket: DTegunov, GitHub: DTegunov)
I think a few help requests could be avoided in the future if cmake made sure GCC's version (though there are probably similar issues with other compilers?) is <= the maximum supported by the CUDA SDK, before make is executed. Especially when running the latter with many threads, NVCC's complaints about GCC can be hard to find.
The text was updated successfully, but these errors were encountered: