Skip to content

SQL storage filter success matches when multiple entries are in db #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

SQL storage filter success matches when multiple entries are in db #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-parents-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@3loop/transaction-decoder': patch
---

SQL Storage filter success matches from database for cases when multiple matches are stored in database
10 changes: 6 additions & 4 deletions packages/transaction-decoder/src/sql/abi-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,15 @@ export const make = (strategies: AbiStore['strategies']) =>
Effect.catchAll(() => Effect.succeed([])),
)

const successItems = items.filter((item) => item.status === 'success')

const item =
items.find((item) => {
successItems.find((item) => {
// Prioritize address over fragments
return item.type === 'address'
}) ?? items[0]
}) ?? successItems[0]

if (item != null && item.status === 'success') {
if (item != null) {
return {
status: 'success',
result: {
Expand All @@ -125,7 +127,7 @@ export const make = (strategies: AbiStore['strategies']) =>
abi: item.abi,
},
} as ContractAbiResult
} else if (item != null && item.status === 'not-found') {
} else if (items[0] != null && items[0].status === 'not-found') {
return {
status: 'not-found',
result: null,
Expand Down
6 changes: 4 additions & 2 deletions packages/transaction-decoder/src/sql/contract-meta-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ export const make = (strategies: ContractMetaStore['strategies']) =>
Effect.catchAll(() => Effect.succeed([])),
)

const item = items[0]
const successItems = items.filter((item) => item.status === 'success')

const item = successItems[0]

if (item != null && item.status === 'success') {
return {
Expand All @@ -92,7 +94,7 @@ export const make = (strategies: ContractMetaStore['strategies']) =>
chainID,
} as ContractData,
}
} else if (item != null && item.status === 'not-found') {
} else if (items[0] != null && items[0].status === 'not-found') {
return {
status: 'not-found',
result: null,
Expand Down
Loading