Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Set __MODBUSMASTER_DEBUG__ to 0 by default #35
First off, great library and thanks for making it, overall I've been very happy with it and it has worked perfectly for my project.
However, these few lines were causing some odd behavior in my system that it took me a while to track down.
The way I constructed my application is part of the reason it took a while, but generally I don't expect a library to change the state of pins in a hidden way. I recommend setting MODBUSMASTER_DEBUG to 0 by default, since if you intend to use the debugging features you will have no issue in enabling them, but most users will probably not be aware of this functionality and are more likely to be using digital pins 4 and 5.
If nothing else, it would be good to make the fact that this is enabled by default very obvious and mention it in the main README.
Thanks again for the library.