Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new templating functions with integration tests #144

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

42atomys
Copy link
Owner

Relative Issues: Resolve #105

Describe the pull request
This pull request introduces a new feature: the addition of new templating functions along with their corresponding integration tests. These templating functions aim to provide more flexibility and functionality for users, while the integration tests ensure that these new functions work as intended in different use-case scenarios. By introducing these new features, we aim to expand the capabilities of our application, improving its functionality and reliability, and enhancing the user experience.

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.21 🎉

Comparison is base (526cdb4) 93.94% compared to head (a3d2fb4) 95.16%.

❗ Current head a3d2fb4 differs from pull request most recent head 2597be3. Consider uploading reports for the commit 2597be3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   93.94%   95.16%   +1.21%     
==========================================
  Files          22       22              
  Lines        1040     1302     +262     
==========================================
+ Hits          977     1239     +262     
  Misses         44       44              
  Partials       19       19              
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 100.00% <ø> (ø)
internal/valuable/valuable.go 96.00% <100.00%> (+0.10%) ⬆️
pkg/formatting/functions.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@42atomys 42atomys merged commit ec2d22d into main Jun 30, 2023
@42atomys 42atomys deleted the feat/news-templete-fonction branch June 30, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow formatting the payload of webhook on the formatting module
2 participants