fix(security): panic due to concurrent map write on handled go routine #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative Issues: Fixes #91
Describe the pull request
In really rare case, when multiples of request is performed on the same spec, an overlap of security pipeline cause a panic due to a concurrent map write. The same pipeline are used for the same spec.
Fixed it by set up a
sync.RWMutex
on pipeline to secure write on go routine and implement aDeepCopy
to make each object individualChecklist
Breaking changes ?
no
Additional context