Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak and mutex usage to have isolation of concurrent pipeline #93

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

42atomys
Copy link
Owner

@42atomys 42atomys commented Jul 9, 2022

Relative Issues: Follow #91 ans #92

Describe the pull request
After release the 0.6.2 version, the application start to have memory leak. I refactor the codebase to secure the template processor with mutex and the pipeline run to clean data after running a deepcopy.

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #93 (2ca3a51) into main (805accf) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   94.08%   94.25%   +0.16%     
==========================================
  Files          22       22              
  Lines         981     1009      +28     
==========================================
+ Hits          923      951      +28     
  Misses         39       39              
  Partials       19       19              
Impacted Files Coverage Δ
internal/server/v1alpha1/handlers.go 93.18% <100.00%> (+0.15%) ⬆️
pkg/factory/factory.go 96.72% <100.00%> (+0.84%) ⬆️
pkg/factory/pipeline.go 100.00% <100.00%> (ø)
pkg/formatting/format.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805accf...2ca3a51. Read the comment docs.

@42atomys 42atomys merged commit c79f50f into main Jul 9, 2022
@42atomys 42atomys deleted the fix/memory_leak_and_mutex branch July 9, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant