Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for experimental WHS #394

Merged
merged 15 commits into from
Nov 14, 2023
Merged

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Nov 14, 2023

Starting from next@14.0.3-canary.6, you can turn on the experimental windowHistorySupport flag to solve issues with prefetch links.

There may be some optimisations to do since Next.js now also patches the history methods (and does so after nuqs), so it looks like there isn't a need for external sync anymore, but this first draft seems to work.

Adding a few more CI cases to test for non-regression.

Note: raw canary (without the flag) still fails due to prefetch reset (see #388), so PR vercel/next.js#58297 is still much needed there. But now at least the flag gives us an escape hatch.

Starting from next@14.0.3-canary.6, you can turn on the
experimental `windowHistorySupport` flag to solve issues
with prefetch links.

There may be some optimisations to do since Next.js now also
patches the history methods (and do so after nuqs), so it looks
like there isn't a need for external sync anymore, but this first
draft seems to work.

Adding a few more CI cases to test for non-regression.
Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-usequerystate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 9:45am

It almost always passes in CI, but fails consistently locally.
IT SHOULD FAIL!!
@franky47 franky47 merged commit e911272 into next Nov 14, 2023
11 of 13 checks passed
@franky47 franky47 deleted the feat/experimental-whs-support branch November 14, 2023 09:50
Copy link

🎉 This PR is included in version 1.12.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant