Tests review Part 2 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/ made test more flexible since numpy version can be changed in the future
6/ added test to verify we are checking for add function '
7/ made test flexible when checking caputured out | added hardcode check
8/ same as previous exercise
9/ same as previous exercise | test that checks for reverse operation made more flexible
10/ made test flexible when checking caputured out | added hardcode check
11/ same as previous exercise || checked array is being used
12/ same as previous exercise
13/ changed function exist test to use regex and be more flexible