Put python-lambda under poetry #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and status/version info, improving doc on testing and installation. Bump version. Relax requirements for downstream libraries. Fix pytest.ini so that invoking pytest with no args works correctly. Adjust dev-requirements.txt to add pygments so that display of README.rst works better in PyCharm. Adjust .gitignore for emacs and PyCharm.
willronchetti
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first cut at getting python-lambda under poetry. It's a pretty simple repo so I don't anticipate too much trouble. The MANIFEST.in suggests there may be files that were supposed to be included that I didn't include, but they look like test files and I'm not sure they should be distributed so I left them out.
These changes will be released as a beta version that we can test in torb and do a later PR to release if it seems good.
Note that I bumped the major version to 2.0.0b1. This is because the change to using poetry requires using Python 3.6. Also, just the use of Poetry could bring incompatible changes, though hopefully not others than the need to use a newer Python. But it seemed prudent to mark the division strongly as a possibly-breaking change.
Also note that I repaired the way the copyrights are handled in the README.rst and the LICENSE file. It was not appropriate to simply remove the old LICENSE notice since the old license requires us not to do that. I think the language I've included is what's needed to join the two.