Normal map prototype #1932
Normal map prototype #1932
Conversation
| * A pixi filter for diffused rendering. | ||
| * @param {gdjs.RuntimeSceneRenderer} runtimeSceneRenderer | ||
| */ | ||
| gdjs.ForwardDiffusedRenderFilter = function (runtimeSceneRenderer) { |
There was a problem hiding this comment.
@4ian how do I import this class? It doesn't fit as an object, behavior or effect, how do I use JsExtension in this case?
EDIT: Also at some point, I'd need to import gdjs.LightsManager as well 🤔.
There was a problem hiding this comment.
As it's part of an extension, it should be included by the extension whenever needed, which is surely whenever one of the new "light" object is used. As you don't have any new "light" object for now, consider either:
- "hacking" you way by adding
addIncludeFileto some action, condition or existing object. Don't forget to put a big TODO - OR maybe this filter should be part of the game engine itself when using pixi? In this case, add it in
GDJS/Runtime/pixi-renderersand list it inExporterHelper::AddLibsIncludein ExporterHelper.cpp. Though this means every game will include it even if not used, so maybe less ideal... but maybe we'll still need this because the rendering of normal map lighting will be tightly integrated in the pixi game engine.
GDJS/Runtime/runtimeobject.js
Outdated
| @@ -337,6 +338,10 @@ gdjs.RuntimeObject.prototype.getRendererObject = function() { | |||
| return undefined; | |||
| }; | |||
|
|
|||
| gdjs.RuntimeObject.prototype.getNormalMapRendererObject = function() { | |||
| return undefined; | |||
There was a problem hiding this comment.
ubernit: I prefer to return null because undefined can mean "you accessed a property that is not even defined, surely something wrong" while null is explictly meaning "this is representing a valid value, but this value is null, i.e: there is no normal map object here".
GDJS/Runtime/runtimeobject.js
Outdated
| @@ -318,6 +318,7 @@ gdjs.RuntimeObject.prototype.deleteFromScene = function(runtimeScene) { | |||
| */ | |||
| gdjs.RuntimeObject.prototype.onDestroyFromScene = function(runtimeScene) { | |||
| var theLayer = runtimeScene.getLayer(this.layer); | |||
|
|
|||
There was a problem hiding this comment.
You'll need to adapt every place where getRendererObject/getRenderer is used to optionally do the same with the normal map object. This is: onDestroyFromScene, setZOrder, setLayer.
Early stage:
Declare abstract methods such as
getNormalMapRendererObject.Get render texture of normal map world.
Add a new RuntimeObject and
gdjs.LightsManagerto track position of lights.Define and apply filter for diffused rendering.