Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation in menu bar #2933

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Add translation in menu bar #2933

merged 1 commit into from
Aug 17, 2021

Conversation

Bouh
Copy link
Collaborator

@Bouh Bouh commented Aug 17, 2021

Fix a part of #969 (comment)

@Bouh Bouh requested a review from 4ian as a code owner August 17, 2021 11:34
@Bouh
Copy link
Collaborator Author

Bouh commented Aug 17, 2021 •
edited
Loading

The remaining items on the report are non-updated POT files.

@Bouh Bouh added the automerge Automatically merge when tests are passing. DON'T FORGET TO EDIT the PR original message and title. label Aug 17, 2021
@4ian
Copy link
Owner

4ian commented Aug 17, 2021

Thanks! These are Electron special menu items, I was thinking they would be handled by the system. But seems that it's not the case, it's actually hardcoded in Electron (https://github.com/electron/electron/blob/888ac65c72df227ed4d65d9177748d4082b13b0f/lib/browser/api/menu-item-roles.ts)

@4ian 4ian merged commit ef198b2 into 4ian:master Aug 17, 2021
@Bouh Bouh deleted the add_translations branch August 17, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ian 4ian Awaiting requested review from 4ian 4ian is a code owner

Assignees
No one assigned
Labels
automerge Automatically merge when tests are passing. DON'T FORGET TO EDIT the PR original message and title.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bouh @4ian