Improve export copy & logic #6023
Conversation
ClementPasteau
commented
Dec 6, 2023
•
ClementPasteau
commented
| componentWillMount() { | ||
| // Fetch limits when the export launcher is opened, to ensure we display the | ||
| // latest limits. | ||
| this.props.authenticatedUser.onSubscriptionUpdated(); |
There was a problem hiding this comment.
I had a case where the call to limits gave me the old value after the build finished (probably some latency on the backend side) and I realised I had not way of getting the right value, apart from going to my profile to retrigger a refresh. (I think it's fine to make this call on every mount?)
There was a problem hiding this comment.
Probably ok, even if a bit "too much" for what is needed.
My only concern is the name "onSubscriptionUpdated" => huh.
I would rather have a "onRefreshUserLimits" (even if the implementation is the same, well, at least the component is expressing its need - it's then the responsibility of the authenticatedUser to try to minimize work as much as it can)
There was a problem hiding this comment.
Updated to only fetch limits 👍
We indeed don't need sub or usages info (I updated other part of the codebase where we fetch too much too)
