New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PixiResourcesLoader #6560

Open

4ian wants to merge 2 commits into master from refactor/pixi-resources-loader

Owner

4ian commented May 12, 2024 •

edited

Rename loadTextures to reloadResources
Remove static methods
Don't pass the class but an instance and remove the Class<> typings.
Add TypeScript typing.

TODO in another PR:

Make getPIXITexture (and others) async. Rework all the on('update') to use a promise instead.
- Replace getTexture to return a Promise<PIXI.Texture> in TileMapHelper. Ensure runtime and editor are adapted.


          Refactor PixiResourcesLoader to remove static methods and type it pro…

56bcb79

…perly in extensions

4ian force-pushed the refactor/pixi-resources-loader branch from 160adfc to 56bcb79 Compare

May 12, 2024 18:06


          Update typing for TileMapHelper

ae0f268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment