Fix tilemap object edge cases causing crashes #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D8H
reviewed
Sep 12, 2024
Extensions/TileMap/JsExtension.js
Outdated
Comment on lines
1908
to
1916
| _placeholderTextNoAtlasPixiObject = new PIXI.Text( | ||
| 'Set up an atlas image\nin the tilemap object.', | ||
| new PIXI.TextStyle({ | ||
| fontFamily: 'Arial', | ||
| fontSize: 16, | ||
| align: 'center', | ||
| padding: 5, | ||
| }) | ||
| ); |
There was a problem hiding this comment.
I wonder if you should change the text of 1 PIXI.Text instead of creating one for each message.
Also, should the placeholders only be instanciated if you actually need them to reduce memory footprint?
There was a problem hiding this comment.
Yes good idea, it was not optimal, I use only one text now.
Regarding the instanciation, I'd rather do pixi container manipulation in the constructor only and then only switch visibility but if you think it's important, I can change this
There was a problem hiding this comment.
I think that's it indeed safer to:
- instantiate what you need (even things that will be hidden) in the constructor
- then only switch visibility or text.
4ian
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tile size is not compatible with atlas and trying to paint:
When atlas is not set:
