Skip to content

Added optional argument for GET params to all query functions + style fixes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Added optional argument for GET params to all query functions + style fixes #20

merged 1 commit into from
Jul 21, 2019

Conversation

abyrne55
Copy link
Contributor

This commit follows up on https://github.com/AICoE/prometheus-api-client-python/pull/19 by adding an optional params argument to every function in prometheus_connect that does GET requests, allowing the user to specify additional URL parameters like "time" or "timeout". I also ran the file through autopep8, cleaned up some of the docstrings, and added more-consistent type hints.

… fixes

This commit follows up on https://github.com/AICoE/prometheus-api-client-python/pull/19 by adding an optional `params` argument to every function in prometheus_connect that does GET requests, allowing the user to specify additional URL parameters like "time" or "timeout". I also ran the file through autopep8, cleaned up some of the docstrings, fixed a few default-value traps, and added more-consistent type hints.
Copy link
Contributor

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hemajv hemajv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@4n4nd
Copy link
Owner

4n4nd commented Jul 21, 2019

Amazing job man! Thanks

@4n4nd 4n4nd merged commit 25e5b7c into 4n4nd:v0.0.2 Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants