Stack & Queue #27
Merged
Stack & Queue #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euchangxian
reviewed
Aug 8, 2023
src/dataStructures/queue/README.md
Outdated
| Deque is a variant of queue where elements can be removed or added from the head and tail of the queue. | ||
| Deque could come in handy when trying to solve sliding window problems. | ||
|
|
||
| However, it is important to note that when implementing a deque, unlike a queue, you would require a doubly linked list. |
There was a problem hiding this comment.
I would recommend rephrasing the statement "unlike a queue, you would require a doubly linked list" as it could lead to misunderstandings that it's the only method of implementing a deque. Perhaps you could consider mentioning that deques can be implemented using arrays or even with 2 stacks!
euchangxian
requested changes
Aug 8, 2023
euchangxian
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored stack & queue, added unit test & README for both.
Monotonic queue will be rewritten, so no unit test yet too.