Skip to content

Conversation

4ndrelim
Copy link
Owner

@4ndrelim 4ndrelim commented Jan 15, 2024

Anyone pls help vet for correctness and clarity! (for DS portion can alr)

Copy link
Collaborator

@euchangxian euchangxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I believe a possible enhancement to the READMEs would be including the practical applications of the data structures implemented. This would allow for better understanding of the problems that the DS solves!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are well-constructed and easy to understand! 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

objects of the smaller tree becomes part of the larger tree (by setting the root node of the smaller tree as a child).
<br>Note that if the trees are of the same size, it does not matter which is assigned.

Notice that trees will only increase in height when it's size is doubled. Working on this intuition, one can show
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@4ndrelim
Copy link
Owner Author

do not merge yet - will add in applications before merging

@euchangxian euchangxian merged commit 5ec7ce7 into main Jan 18, 2024
@euchangxian euchangxian deleted the branch-DisjointSet branch January 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants