Improve attachment filename extraction #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already handling the case where filename returned by
msg.get_filename()
returned a cropped version of the filename. In that case we took the filename from the lastfilename
parameter of thecontent-disposition
headers. It now turns out that sometimesmsg.get_filename()
returns a normalized version of the filename, e.g. without umlauts. This is also not what we want and using the lastfilename
parameter of thecontent-disposition
headers would also fix the issue. So it seems we can always take the last one when there are several.Note that I changed/fixed a few other things:
content-disposition
header when we were actually looking at thecontent-type
header.Message.get_param
does.For https://4teamwork.atlassian.net/browse/CA-5456