-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of url format for ContentHostingConfiguration.entryPointPath at M1 can disallow relative paths #36
Comments
Problem description seems reasonable, @davidjwbbc, but I think a better solution would be to update TS26512_CommonData.yaml as follows:
TS26512_M1_ContentHostingProvisioning.yaml is updated to use the new common data types. Prototypes here: |
This uses the suggested implementations from 5G-MAG/Standards#36 Add RelativeUrl and AbsoluteUrl types to TS26512_CommonData.yaml and reference them in appropriate places in TS26512_M1_ContentHostingProvisioning.yaml.
The TS26512_CommonData.yaml linked above is missing the last part of the file, I've replaced it in the version I've used by grabbing the extra |
CR pack SP-250253 approved at SA#99 Plenary meeting in Rotterdam. |
Description
In TS 26.512 v17.3.0 Annex C.3.5 the OpenAPI YAML uses the
TS26512_CommonData.yaml#/components/schemas/Url
type for theContentHostingConfiguration.entryPointPath
which is atype: string
withformat: uri
.OpenAPI 3.0 uses the JSON Schema to specify the
type
andformat
combinations available. For thestring
type theuri
format is specified as being the URI from RFC 3986. However this statement is ambiguous as it does not specify whether it is referring to URI as the thing specified by RFC 3986 or to theURI
BNF element specified within RFC 3986. Some JSON Schema parsers and OpenAPI processors have chosen the latter, limiting the strings to URIs which followscheme ":" hier-part [ "?" query ] [ "#" fragment ]
. Since this format mandates the scheme, a simple relative path is not permitted.My understanding is that the
ContentHostingConfiguration.entryPointPath
property is supposed to hold a relative path, but cannot if theuri
format is used in the strict sense by an OpenAPI processor (such an example tool is the openapi-generator).The JSON Schema (Draft 6 and above) also contains a
uri-reference
format which explicitly uses theURI-Reference
BNF node from RFC 3986. This format represents either a full URI or a relative path.Suggested solution
Change the
entryPointPath
data type from:to
This removes the ambiguity and will allow relative paths in this field in all OpenAPI processors.
The text was updated successfully, but these errors were encountered: