Fixes for observed installation issues. #40
Conversation
Intercepts all standard build backend functions and runs checks to ensure that the OpenAPI bindings have been built. This fixes issues where rt_5gms_as.openapi_5g was not being included in some distributions or installs.
Updates the developer documentation to include new files and to change the names of renamed files in this project. Include information in the main README to make it clear that the application requires root privileges to run when used with the default configuration.
davidjwbbc
added
bug
docs/README.md
Outdated
| - generate_openapi - Will generate the OpenAPI python modules if not already present. | ||
| - docs/ - Development documentation and examples. | ||
| - generate_5gms_as_openapi - Will generate the OpenAPI python modules if not already present. | ||
| - docs/ - Development documentation and examples. | ||
| - README.md - This document. | ||
| - chc.json - An example ContentHostingConfiguration JSON file which provisions a pull-ingest AS for "Big Buck Bunny". |
There was a problem hiding this comment.
Shouldn't chc.json be removed now that the example is available from rt-common-shared/5gms?
There was a problem hiding this comment.
There's a file inside docs/ which is not on the list? example-application-server.conf
the json has been moved to external/rt-commom-shared/..., isn't it?
There was a problem hiding this comment.
These are the two things I've fixed directly:
#39 (comment)
There was a problem hiding this comment.
Thanks, @davidjwbbc.
Looks good apart from the above comment about removing chc.json from docs/README.md.
Let's see what @dsilhavy and @jordijoangimenez think.
|
Changes looks good to me, one observation: I am still getting a |
../docs/rt-common-shared/5gms/examples/ContentHostingConfiguration_Big-Buck-Bunny_pull-ingest.json is under ../external/
|
I wonder if there's a problem not being reported in the generator script. You could try running |
This removes the description for chc.json, which has now moved to rt-common-shared and adds a description for the example application configuration file.
|
Blocked awaiting approval from @dsilhavy and @jordijoangimenez. Has @davidjwbbc addressed your feedback satisfactorily? If so, please hit the Approve button. |
|
I believe this looks good. Daniel, if you are happy please go ahead. |
Closes #39.
This PR fixes an issue with the creation of the OpenAPI bindings during some distribution or installation processes.
This also updates the documentation for the project to include new files, renamed files and to clarify the user privileges needed to run this with its default configuration.