big refactoring and improvement #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactoring folder (more logic i hope) - improve server/client to permit developer to switch the serializer used - better Iconnection creation on socket.accept() (first attempt) on server to avoid code duplication. Now you can precise a type of connection on Serveur creation - improve FlashServer using the new Iconnection creation. (remove code duplication) - Some minor refacto on EventManager to explicit Client/server manager used. (try to add some improvement but i remove it from this commit, see 5mixer branches "event_refactor") - Refactoring of TcpClient/TcpFlashClient - Manager Connect/disconnect callback on client/server - Clean some useless/ugly code - other minor stuff i don't remember :) - todo : add commentary and refactoring class to standardize typographie (using lower camel case ?) Tested & working (all localy) : - neko : server/client - c++ server/client - flash : client (connecting to a neko/c++ server) not tested : websocket protocol
|
Wow, thanks man! Huge amount of work, kudos to you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used
server to avoid code duplication. Now you can precise a type of
connection on Serveur creation. (first attempt)
duplication)
used. (try to add some improvement but i remove it from this commit, see
5mixer branches "event_refactor")
typographie (using lower camel case ?)
Tested & working (all localy) :
not tested : websocket protocol