Fix bug in the (admitedly fake) shadow. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that the variable that was named "shadow_radius2" is actually compared to the square of distances, so I put it at 4 for a non-squared radius of 2, matching the radius of the sphere.Notice that the variable that was named "shadow_radius" is actually compared to the square of distances, so I put it at 4 for a non-squared radius of 2, matching the radius of the sphere, and renamed the variable to "shadow_radius2".
fidergo-stephane-gourichon
force-pushed
the
fix_shadow
branch
from
e4fe90b
to
a3f5b9c
Compare
This was referenced Jan 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that the variable that was named "shadow_radius" is actually compared to the square of distances, so I put it at 4 for a non-squared radius of 2, matching the radius of the sphere, and renamed the variable to "shadow_radius2".
Best enjoyed with #4 and #5 applied.