Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - TypeScript Complete Migration -- Raid In Progress #596

Closed
wants to merge 53 commits into from

Conversation

JacobMGEvans
Copy link

Resolves #595

@ghiscoding
Copy link
Collaborator

ghiscoding commented Mar 31, 2021

@JacobMGEvans are you still intending to make 1 big PR? If so it might be better to rename this PR with WIP as a Prefix so we don't merge by mistake. I'll assume that is what your intention is, so I'll add WIP to it, we have this WIP plugin that helps identify what is ready and what is not.. thanks

@ghiscoding ghiscoding changed the title TypeScript Complete Migration -- Raid In Progress WIP - TypeScript Complete Migration -- Raid In Progress Mar 31, 2021
YPAzevedo and others added 25 commits April 2, 2021 10:38
* chore: migrate cypress to ts

* chore: fix typo in type
…p-ts-conversion

fix(auto-tooltips): converted auto-tooltip plugin + some ts defaults
migrate slick.formatters, add JQuery type definitions and tsconfig changes
migrate plugins/slick.cellcopymanager.js to ts
…model-yahoo

migrate slick.remotemodel-yahoo to ts
fix setTimeout return type use window.setTimeout
JacobMGEvans and others added 25 commits April 10, 2021 21:04
…decorator-conversion

ts-conversion: cellRangeDecorator (plugin)
…ip-ts-conversion-update

fix: AutoTooltips ts conversion update
- issue with .call having multiple arguments
- EventData is given a constructor signiture with new cast
- Added a Map interface
- Created a more comphrensive MapConstructor interface
borrowing from Lodash ES5 compatible MapConstructor
- Made the types intergrated into the methods generic
with the generic interfaces for better inference of types from user input
- Caveat the types are crude
more generic types and uses types from other modules
would greatly benefit the core module
- slick.state had unused variables that I converted to underscore -- TS ignores that assignment
@ghiscoding
Copy link
Collaborator

Better late than never, the project is being rewritten in TypeScript and will be eventually release as v5.0 (see Roadmap to v5

I am using esbuild to still provide iife legacy support, at the end we will have 3 new build format types (iife, cjs and esm). The great thing about esbuild is that it supports JS and even TS files out of the box, with this new approach we will be able to support both legacy (iife) and modern (esm) and keep everyone happy.

Thanks guys for giving it a try in the past, it will finally happen nonetheless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Typescript Conversion -- OSRG Raid
7 participants