Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - TypeScript Complete Migration -- Raid In Progress #596

Closed
wants to merge 53 commits into from
Closed

WIP - TypeScript Complete Migration -- Raid In Progress #596

wants to merge 53 commits into from

Conversation

JacobMGEvans
Copy link

Resolves #595

@ghiscoding
Copy link
Collaborator

ghiscoding commented Mar 31, 2021 •
edited
Loading

@JacobMGEvans are you still intending to make 1 big PR? If so it might be better to rename this PR with WIP as a Prefix so we don't merge by mistake. I'll assume that is what your intention is, so I'll add WIP to it, we have this WIP plugin that helps identify what is ready and what is not.. thanks

@ghiscoding ghiscoding changed the title TypeScript Complete Migration -- Raid In Progress WIP - TypeScript Complete Migration -- Raid In Progress Mar 31, 2021
YPAzevedo and others added 25 commits April 2, 2021 10:38
@YPAzevedo
chore: migrate cypress to ts (#3)
aa3dbe5 
* chore: migrate cypress to ts

* chore: fix typo in type
migrate slick.formatters, add JQuery definitions and tsconfig changes
2c18640
@mitchelvanbever
fix(auto-tooltips): converted auto-tooltip plugin + some ts defaults
4bee4e1
@mitchelvanbever
chore(cypress): added cypress-testing-library
6e576e4
@JacobMGEvans
Merge pull request #7 from mitchelvanbever/mitchelvanbever/autotoolti…
e95e908 
…p-ts-conversion

fix(auto-tooltips): converted auto-tooltip plugin + some ts defaults
@YPAzevedo
Merge branch 'master' of github.com:OpenSourceRaidGuild/SlickGrid int…
15e2b24 
…o YPAzevedo/migrate-slick-formatter
@YPAzevedo
minor review request changes and tsconfig changes
9d707b0
@JacobMGEvans
Merge pull request #6 from YPAzevedo/YPAzevedo/migrate-slick-formatter
f463fc7 
migrate slick.formatters, add JQuery type definitions and tsconfig changes
@mpeyper
feat: migrate slick.remotemodel to typescript (#9)
9daaf11
@rbusquet
migrate plugins/slick.cellcopymanager.js to ts
c28d7a4
@rbusquet
use @ scripts in cypress tests
cc73081
@rbusquet
fix tests
642a51a
@mpeyper
Merge pull request #11 from rbusquet/rbusquet
ebaf766 
migrate plugins/slick.cellcopymanager.js to ts
@YPAzevedo
migrate slick.remotemodel-yahoo to ts
cc76958
@JacobMGEvans
Merge pull request #13 from YPAzevedo/YPAzevedo/migrate-slick-remote-…
fd3d1d9 
…model-yahoo

migrate slick.remotemodel-yahoo to ts
@YPAzevedo
fix setTimeout return type use window.setTimeout
b90ae0e
@JacobMGEvans
Merge pull request #15 from YPAzevedo/YPAzevedo/fix-set-timeout-type
94a85d6 
fix setTimeout return type use window.setTimeout
@YPAzevedo
migrate index.js to ts
0d11566
@JacobMGEvans
Merge pull request #17 from YPAzevedo/YPAzevedo/migrate-index-ts
e86831d 
migrate index.js to ts
@MohitPopli
Migrating slick state file
371fad8
@JacobMGEvans
Merge pull request #19 from MohitPopli/mohit/slick_state
833b40b 
Migrating slick state file
@mitchelvanbever
fix(types): copied types from other repo for consistency
5af037c
@mitchelvanbever
chore(build): updated build
1967c6b
@mitchelvanbever
chore(ts-conversion): converted cellRangeDecorator to typescript
98d2d96
@mitchelvanbever
chore(cypress): upgraded to v7.0.1
00ea7f6
JacobMGEvans and others added 25 commits April 10, 2021 21:04
@JacobMGEvans
Merge pull request #41 from mitchelvanbever/mitchelvanbever/cellrange…
2410cbc 
…decorator-conversion

ts-conversion: cellRangeDecorator (plugin)
@JacobMGEvans
Merge pull request #20 from mitchelvanbever/mitchelvanbever/autotoolt…
34e94e1 
…ip-ts-conversion-update

fix: AutoTooltips ts conversion update
@JacobMGEvans
Started work on slick.core
00195b3
@JacobMGEvans
interface typo
4ab7407
@JacobMGEvans
Event Typed with interface
ba718c3 
- issue with .call having multiple arguments
- EventData is given a constructor signiture with new cast
@JacobMGEvans
Crude types for Range, and Event related contructors
0594cfc
@JacobMGEvans
NonDataItem constructor signiture added
4b5d44e
@JacobMGEvans
More Constructor signitures and interfaces
c0bde7c
@JacobMGEvans
started interface for TreeColumn
8c77c4c
@JacobMGEvans
subscribe type changed to constructor signiture & added constructor s…
a2a13b9 
…igntures to core methods
@JacobMGEvans
Additional interface typing for TreeColumns
ca51d4d
@JacobMGEvans
Types Map
e967c0b 
- Added a Map interface
- Created a more comphrensive MapConstructor interface
borrowing from Lodash ES5 compatible MapConstructor
- Made the types intergrated into the methods generic
with the generic interfaces for better inference of types from user input
@JacobMGEvans
Call in notify method still having TS issue
2686e44
@JacobMGEvans
Types working for core
857d956 
- Caveat the types are crude
more generic types and uses types from other modules
would greatly benefit the core module
@JacobMGEvans
temp TS Lint ignore added for .call in core
e3b8699 
- slick.state had unused variables that I converted to underscore -- TS ignores that assignment
@JacobMGEvans
Added prefixed underscores to seemingly unused params
e6db205
@JacobMGEvans
tsc build step
0d48db4
@JacobMGEvans
switched the core script with TS output reference
23cd6bc
@JacobMGEvans
removed unused params
dc17a5b
@JacobMGEvans
Merge pull request #42 from OpenSourceRaidGuild/jacobmgevans
e0d66c1 
WIP slick.core
@JacobMGEvans
remove constructor signiture from EventHandler
5ab2aaf
@JacobMGEvans
internal core reference to EventHandler to Function signiture
7670ac3
@JacobMGEvans
Merge pull request #43 from OpenSourceRaidGuild/jacobmgevans
54589ab 
Jacobmgevans
@JacobMGEvans
Revert "Jacobmgevans"
a90b536
@JacobMGEvans
Merge pull request #44 from OpenSourceRaidGuild/revert-43-jacobmgevans
991f775 
Revert "Jacobmgevans"
@ghiscoding
Copy link
Collaborator

Better late than never, the project is being rewritten in TypeScript and will be eventually release as v5.0 (see Roadmap to v5

I am using esbuild to still provide iife legacy support, at the end we will have 3 new build format types (iife, cjs and esm). The great thing about esbuild is that it supports JS and even TS files out of the box, with this new approach we will be able to support both legacy (iife) and modern (esm) and keep everyone happy.

Thanks guys for giving it a try in the past, it will finally happen nonetheless :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete Typescript Conversion -- OSRG Raid
7 participants
@JacobMGEvans @ghiscoding @YPAzevedo @mitchelvanbever @mpeyper @rbusquet @MohitPopli