feat: mouseWheelSensitivityX and mouseWheelSensitivityY options #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol wheel sensitivity
|
I ended up not using this code, so not sure if this is relevant or not. I use a trackball, and in my environment the mouse wheel sensitivity increases when enableMouseWheelScrollHandler is enabled. But other people had a different experience, and we ended up keeping the default values. |
|
closing since I don't think this is needed and the codebase changed a lot since then and will change even more when Roadmap to v4.0 is soon to be released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I set enableMouseWheelScrollHandler, the mouse wheel sensitivity increases a lot. To fix that, I put these constants that were already being used as options.
In my first experiments, 3 would be a better default value for both. It's closer to the sensitivity when enableMouseWheelScrollHandler is false, and more ergonomic.