feat(dataView): add option to apply row selection to all pages

[ghiscoding]

• supersede WIP - fix(dataView): add option to apply row selection to all pages #689, most Grid & DataView changes were kept with some small changes & fixes, also added more Cypress E2E tests
• when having pages and syncGridSelection is called with preserveHiddenOnSelectionChange, clicking on Select All checkbox:
  • it will apply row selections on all rows
  • if nothing is selected and we filter data, then we click on Select All, it will apply row selections only to the item being filtered and if we remove filters then the Select All is not expect to be selected

Changes compared to previous PR #689

• most of the files are the same (slick.grid.js, slick.checkboxselectcolumn.js, example-checkbox-header-row.html), however slick.dataview.js got modified a bit
• added back filteredIds which was added originally but removed in PR WIP - fix(dataView): add option to apply row selection to all pages #689
• the method syncGridSelection had a onSelectedRowIdsChanged.subscribe (1) inside it but there was a racing issue because the Example (demo) is also calling onSelectedRowIdsChanged (2), but the sequence should be run (1) and then only after run (2), we could fix this by adding a setTimeout but it isn't a very clean approach, however we can simply change the (1) from onSelectedRowIdsChanged.subscribe to a function named selectedRowChangedFn and execute it prior to (2), this way is a clean approach and it doesn't have any racing issue since we are only left with the (2) subscribe
• I still don't understand the difference between preserveHidden and preserveHiddenOnSelectionChange but as far as I see it, the Example only works as intended (the steps written above) when these 2 flags are set to preserveHidden: false and preserveHiddenOnSelectionChange: true. I'm not sure if this is intended @arashdalir could probably confirm
• this PR supersede WIP - fix(dataView): add option to apply row selection to all pages #689 and is based on SlickGrid v3.x
• I don't think the changes to slick.grid.js are required for applying Select All across all pages, we should probably move that code change to a separate PR
  • rollback slick.grid.js changes, since there's already another PR fixed issue #546 - broken multi column sort with invisible columns #549 and we should keep PR as small as possible

Requires Confirmations before merging

It requires review & confirmation by @arashdalir before merging this PR

[ghiscoding]

[ghiscoding]

@6pac it doesn't look like I'll get a review from that other person since he doesn't seem to be around. This PR is been pending for over a month and I'm finished testing it in my libs and fixed all issues I found.

So can we merge it?
Note that I'm not ready for a new release just yet, I have 2 more PRs to do after this one. Thanks

[arashdalir]

sorry, I have not been able to merge your changes into our system and see if there are any issues; will not be able to test in the next few days, because we have a project deadline and I cannot test stuff which are not related to it. sorry again

…

On Thu, Feb 2, 2023 at 5:20 PM Ghislain B. ***@***.***> wrote: @6pac <https://github.com/6pac> it doesn't look like I'll get a review from that other person since he doesn't seem to be around. This PR is been pending for over a month and I'm finished testing it in my libs. So can we merge it, I'm also not yet ready for a new release, I have 2 more PRs to do after this one — Reply to this email directly, view it on GitHub <#716 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWDCKVIKA7Q3FB7NPDCCWLWVPNDLANCNFSM6AAAAAATKC7IIM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ghiscoding]

@arashdalir
That's ok, I want to proceed with this change, you might have to adjust some property name when you merge it in your grid but it should be easy enough, the implementation remains the same with the adjustment you provided.

@6pac
let's merge it