Horizontally stacked flexbox and more #10
Conversation
|
Hey there, thanks for investing time into stickers, its awesome to see it being used to such extent. |
| // SetMinWidth sets the cells minimum width, this will not disable responsivness | ||
| func (r *FlexBoxCell) SetMinWidth(value int) *FlexBoxCell { | ||
| // SetMinWidth sets the cells minimum width, this will not disable responsivness. | ||
| // This has only an effect to cells of a normal FlexBox, not a HorizontalFlexBox. |
| @@ -66,8 +67,9 @@ func (r *FlexBoxRow) GetCellCopy(index int) *FlexBoxCell { | |||
|
|
|||
| // GetCellWithID returns the cell with the given ID if existing | |||
| // note: forces the recalculation if found | |||
| // returns nil if not found | |||
| func (r *FlexBoxRow) GetCellWithID(id string) *FlexBoxCell { | |||
| // | |||
There was a problem hiding this comment.
Feels like HorizontalFlexBox is basically mirror of the FlexBox, this is not really ideal as it requires user to make a change on two essentially same functions, it might be better to create base struct that FlexBox and HorizontalFlexBox would inherit and build upon.
I would leave this increment for the future PR to avoid this PR being overly complex.
|
Sorry for the massive lag, time became the rarest commodity for the past few months. [update] |
Hi,
Initially I just wanted to add support for a horizontally stacked flexbox but somehow I ended up doing a lot more changes to fit my needs. Basically all of them are breaking.
I changed the following things:
stickers.FlexBoxRow->flexbox.RowPlease feel free to adopt whatever you like, maybe for v2 of this library, since it's very breaking.