-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to enable live updating of Tables #12
Conversation
add UpdateByAsc and UpdateByDesc methods add GetOrder method these methods provide the ability to clear the contents of an existing table so that new data can be added prior to re-rendering, enabling live updating tables
A few minor additive changes in this PR. Was trying your very nice Table module out with the intent of using it as a live updating view for a gRPC service, but I was not able to find any way in the implementation to update rows after adding them (either updating their content, or removing rows that had expired). I started by adding a ClearRows() method, but found that just clearing the rows and re-adding a new set during the model Update() resulted in any ordering being lost, and just persisting & re-executing OrderByColumn() would toggle between ascending and descending. Adding in the OrderByAsc/Desc provided a deterministic way of re-applying any previous ordering that can now be retrieved with GetOrder(). Works pretty well in practice, happy for any feedback or suggestions. |
Hey there @drmille2, thanks for taking time to contribute to the stickers! [Update] Sorry for the lag, I had no time to commit to stickers past few months, still is bit hectic but I will try to be around more :) |
Went ahead and merged in the latest changes from master, so the PR should be compatible with the breaking changes from #10 now, and added a deprecation warning to |
Not sure how I missed this one, sorry for lag, will check it out soon! |
Any updates on this--concerns or other things you'd like to see addressed? |
@76creates Any chance this can get merged? Or are there any workarounds I can use? I tried recreating the table but it doesn't seem to be working. |
@spogatetz checked it again, all legit, merged ⚡ |
Released with 1.4.1 |
add UpdateByAsc and UpdateByDesc methods
add GetOrder method
these methods provide the ability to clear the contents of an existing table so that new data can be added prior to re-rendering, enabling live updating tables
example usage: