Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #120 #122

Closed
wants to merge 1 commit into from
Closed

Conversation

rotobash
Copy link

This should fix the spacemen being drawn over the text.

The z-index controls the stack order of the elements, I've set this to
ten to ensure that it is the top element. Cheers.

This should fix the spacemen being drawn over the text.

The z-index controls the stack order of the elements, I've set this to
ten to ensure that it is the top element. Cheers.
@rotobash rotobash closed this Jun 13, 2015
@rotobash rotobash deleted the gameover-text-clip-fix branch June 13, 2015 16:53
@rotobash rotobash restored the gameover-text-clip-fix branch June 13, 2015 16:53
@rotobash
Copy link
Author

This particular solution doesn't look like that would work. I'll fix it and reopen it then. Sorry about that.

@7yl4r
Copy link
Owner

7yl4r commented Jun 13, 2015

Does that fix not work? Looks good in theory, but I'm no css pro.

@rotobash
Copy link
Author

I don't think it would have worked because the HTML needed some tweaking. I'm pretty sure z-indexing only applies to div tags. I changed the li tag to a p tag (unless it was supposed to be actually part of a bigger list?) and wrapped it in a div, the div tag now has the class game-over-text.

I will update it in my branch, but my linux distro is a bit buggered at the moment so I can't test it (using windows right now). Theoretically, it should work; practically, I don't know...

@7yl4r
Copy link
Owner

7yl4r commented Jun 14, 2015

Alright, I'll watch and give it a test when it's ready.

On Sat, Jun 13, 2015, 7:22 PM thegluestickman notifications@github.com
wrote:

I don't think it would have worked because the HTML needed some tweaking.
I'm pretty sure z-indexing only applies to div tags. I changed the li tag
to a p tag (unless it was supposed to be actually part of a bigger list?)
and wrapped it in a div, the div tag now has the class game-over-text.

I will update it in my branch, but my linux distro is a bit buggered at
the moment so I can't test it (using windows right now). Theoretically,
it should work; practically, I don't know...


Reply to this email directly or view it on GitHub
#122 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants