Skip to content

fix: Value could become integer #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2023
Merged

fix: Value could become integer #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Forms/Select.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ private function selectDropdown(): Element
{
$elements = [];
foreach ($this->options as $value => $content) {
$value = strval($value);
$option = Element::option($content)->props('value ' . $value);
if ($this->isSelected($value)) {
$option = $option->prop('selected selected');
Expand All @@ -150,6 +151,7 @@ private function selectOther(): Element
$type = 'checkbox';
}
foreach ($this->options as $value => $content) {
$value = strval($value);
$id = $this->name . '-' . $value;
$label = Element::label($content)->props('for ' . $id);
$input = Element::input()->omitEndTag()->props(
Expand Down
21 changes: 21 additions & 0 deletions tests/Forms/SelectTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,25 @@ public function is_expected_base(): void // phpcs:ignore

$this->assertSame($expected, $result);
}

/**
* @test
*/
public function error_is_selected_value_always_string(): void // phpcs:ignore
{
$expected = <<<html
<div><label for="select">Select your option</label><select id="select" name="select"><option value="0">display</option></select></div>
html;

// Even with strict types, number-based keys become integers
$result = (string) Select::create(
'Select your option',
'select',
[
'0' => 'display'
]
);

$this->assertSame($expected, $result);
}
}