fix: Don't set the package variable for the new Resolver Template #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penard-cb
changed the title
penard-cb
changed the title
|
@StevenACoffman looks like I made a go blunder in my last PR. This makes sure I don't set the variable at the package level and only when the plugin is called. |
|
Thanks for catching this! Luckily, I hadn't pushed out a new release with the bug. I appreciate your working on this, and for diligently testing it. Do mind commenting on some of your motivating use cases here for posterity? I'm also looking forward to your next contribution here! Thanks for your good work! |
|
Thanks @StevenACoffman! The motivation on this is to ensure I can apply some boilerplate logic to my resolvers. This will help implementation teams understand what needs doing a bit better and get help. Also in some schemas I can template out the full resolver implementation as it is fairly straight forward just extremely repetitive. This makes it possible for me to do that per schema. |
This was referenced Jul 25, 2023
mergify bot
referenced
this pull request
in infratographer/metadata-api
Aug 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/99designs/gqlgen](https://togithub.com/99designs/gqlgen) | require | patch | `v0.17.34` -> `v0.17.36` | --- ### Release Notes <details> <summary>99designs/gqlgen (github.com/99designs/gqlgen)</summary> ### [`v0.17.36`](https://togithub.com/99designs/gqlgen/releases/tag/v0.17.36) [Compare Source](https://togithub.com/99designs/gqlgen/compare/v0.17.35...v0.17.36) #### What's Changed - Update gqlparser to v2.5.8 by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/99designs/gqlgen/pull/2716](https://togithub.com/99designs/gqlgen/pull/2716) - Added go mod tidy to quick start guide by [@​UnAfraid](https://togithub.com/UnAfraid) in [https://github.com/99designs/gqlgen/pull/2718](https://togithub.com/99designs/gqlgen/pull/2718) - docs: update dataloader docs by [@​zenyui](https://togithub.com/zenyui) in [https://github.com/99designs/gqlgen/pull/2719](https://togithub.com/99designs/gqlgen/pull/2719) - Fix docs by [@​zenyui](https://togithub.com/zenyui) in [https://github.com/99designs/gqlgen/pull/2722](https://togithub.com/99designs/gqlgen/pull/2722) - Fixed Data Loader docs by [@​UnAfraid](https://togithub.com/UnAfraid) in [https://github.com/99designs/gqlgen/pull/2723](https://togithub.com/99designs/gqlgen/pull/2723) - Make the resolver implementation configurable via a new template resolver.gotpl by [@​penard-cb](https://togithub.com/penard-cb) in [https://github.com/99designs/gqlgen/pull/2720](https://togithub.com/99designs/gqlgen/pull/2720) - fix: Don't set the package variable for the new Resolver Template by [@​penard-cb](https://togithub.com/penard-cb) in [https://github.com/99designs/gqlgen/pull/2725](https://togithub.com/99designs/gqlgen/pull/2725) - Make models configurable via template by [@​penard-cb](https://togithub.com/penard-cb) in [https://github.com/99designs/gqlgen/pull/2730](https://togithub.com/99designs/gqlgen/pull/2730) - Fix plugin template resolution by [@​douglaswth](https://togithub.com/douglaswth) in [https://github.com/99designs/gqlgen/pull/2733](https://togithub.com/99designs/gqlgen/pull/2733) #### New Contributors - [@​penard-cb](https://togithub.com/penard-cb) made their first contribution in [https://github.com/99designs/gqlgen/pull/2720](https://togithub.com/99designs/gqlgen/pull/2720) - [@​douglaswth](https://togithub.com/douglaswth) made their first contribution in [https://github.com/99designs/gqlgen/pull/2733](https://togithub.com/99designs/gqlgen/pull/2733) **Full Changelog**: 99designs/gqlgen@v0.17.35...v0.17.36 ### [`v0.17.35`](https://togithub.com/99designs/gqlgen/blob/HEAD/CHANGELOG.md#v01735---2023-07-15) [Compare Source](https://togithub.com/99designs/gqlgen/compare/v0.17.34...v0.17.35) - <a href="https://togithub.com/99designs/gqlgen/commit/05006bf1dcb9451b0960d07fd68370145c2697b4"><tt>[`05006bf`](https://togithub.com/99designs/gqlgen/commit/05006bf1)</tt></a> release v0.17.35 - <a href="https://togithub.com/99designs/gqlgen/commit/d95d614f8fc2c5983390adf0507027a1efdd778a"><tt>[`d95d614`](https://togithub.com/99designs/gqlgen/commit/d95d614f)</tt></a> Update gqlparser to v2.5.7 (<a href="https://togithub.com/99designs/gqlgen/pull/2714">[#​2714](https://togithub.com/99designs/gqlgen/issues/2714)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/8c378e6bdd1962822216053ae2c01e89ef35034a"><tt>[`8c378e6`](https://togithub.com/99designs/gqlgen/commit/8c378e6b)</tt></a> Updated GraphiQL playground 2.0.7 -> 3.0.1 and react 17 -> 18 (<a href="https://togithub.com/99designs/gqlgen/pull/2713">[#​2713](https://togithub.com/99designs/gqlgen/issues/2713)</a>) <dl><dd><details><summary><a href="https://togithub.com/99designs/gqlgen/commit/7880739d48a9aa2d6f4be87129cb361d2c2c0345"><tt>7880739d</tt></a> Add op ctx safety for apollo tracing (<a href="https://togithub.com/99designs/gqlgen/pull/2709">#​2709</a>)</summary> - Add automated tests for both tracing and tracer to simulate a client disconnect - Check for existence of operation context before proceeding to avoid panic </details></dd></dl> - <a href="https://togithub.com/99designs/gqlgen/commit/6ed9337bce0daf05c1c3bda29fd86368768cdb68"><tt>[`6ed9337`](https://togithub.com/99designs/gqlgen/commit/6ed9337b)</tt></a> fix function name in comment (<a href="https://togithub.com/99designs/gqlgen/pull/2707">[#​2707](https://togithub.com/99designs/gqlgen/issues/2707)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/2cfb9f98c4c2b090a6a65816ed28a67501303768"><tt>[`2cfb9f9`](https://togithub.com/99designs/gqlgen/commit/2cfb9f98)</tt></a> Fix apollo integrity hash (<a href="https://togithub.com/99designs/gqlgen/pull/2706">[#​2706](https://togithub.com/99designs/gqlgen/issues/2706)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/470fca87d3002399fb02e14cf014c3c26755d87b"><tt>[`470fca8`](https://togithub.com/99designs/gqlgen/commit/470fca87)</tt></a> Update gqlparser again (<a href="https://togithub.com/99designs/gqlgen/pull/2697">[#​2697](https://togithub.com/99designs/gqlgen/issues/2697)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/280441b1a0c46652f3b16692839fbdbd024aa06d"><tt>[`280441b`](https://togithub.com/99designs/gqlgen/commit/280441b1)</tt></a> Update changelog - <a href="https://togithub.com/99designs/gqlgen/commit/5bc36e142dfffceb96ac8b23bb9c13b492504474"><tt>[`5bc36e1`](https://togithub.com/99designs/gqlgen/commit/5bc36e14)</tt></a> v0.17.34 postrelease bump <!-- end of Commits --> <!-- end of Else --> <!-- end of If NoteGroups --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/infratographer/metadata-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjQzLjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
github-merge-queue bot
referenced
this pull request
in infratographer/x
Aug 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/99designs/gqlgen](https://togithub.com/99designs/gqlgen) | require | patch | `v0.17.34` -> `v0.17.36` | --- ### Release Notes <details> <summary>99designs/gqlgen (github.com/99designs/gqlgen)</summary> ### [`v0.17.36`](https://togithub.com/99designs/gqlgen/releases/tag/v0.17.36) [Compare Source](https://togithub.com/99designs/gqlgen/compare/v0.17.35...v0.17.36) #### What's Changed - Update gqlparser to v2.5.8 by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/99designs/gqlgen/pull/2716](https://togithub.com/99designs/gqlgen/pull/2716) - Added go mod tidy to quick start guide by [@​UnAfraid](https://togithub.com/UnAfraid) in [https://github.com/99designs/gqlgen/pull/2718](https://togithub.com/99designs/gqlgen/pull/2718) - docs: update dataloader docs by [@​zenyui](https://togithub.com/zenyui) in [https://github.com/99designs/gqlgen/pull/2719](https://togithub.com/99designs/gqlgen/pull/2719) - Fix docs by [@​zenyui](https://togithub.com/zenyui) in [https://github.com/99designs/gqlgen/pull/2722](https://togithub.com/99designs/gqlgen/pull/2722) - Fixed Data Loader docs by [@​UnAfraid](https://togithub.com/UnAfraid) in [https://github.com/99designs/gqlgen/pull/2723](https://togithub.com/99designs/gqlgen/pull/2723) - Make the resolver implementation configurable via a new template resolver.gotpl by [@​penard-cb](https://togithub.com/penard-cb) in [https://github.com/99designs/gqlgen/pull/2720](https://togithub.com/99designs/gqlgen/pull/2720) - fix: Don't set the package variable for the new Resolver Template by [@​penard-cb](https://togithub.com/penard-cb) in [https://github.com/99designs/gqlgen/pull/2725](https://togithub.com/99designs/gqlgen/pull/2725) - Make models configurable via template by [@​penard-cb](https://togithub.com/penard-cb) in [https://github.com/99designs/gqlgen/pull/2730](https://togithub.com/99designs/gqlgen/pull/2730) - Fix plugin template resolution by [@​douglaswth](https://togithub.com/douglaswth) in [https://github.com/99designs/gqlgen/pull/2733](https://togithub.com/99designs/gqlgen/pull/2733) #### New Contributors - [@​penard-cb](https://togithub.com/penard-cb) made their first contribution in [https://github.com/99designs/gqlgen/pull/2720](https://togithub.com/99designs/gqlgen/pull/2720) - [@​douglaswth](https://togithub.com/douglaswth) made their first contribution in [https://github.com/99designs/gqlgen/pull/2733](https://togithub.com/99designs/gqlgen/pull/2733) **Full Changelog**: 99designs/gqlgen@v0.17.35...v0.17.36 ### [`v0.17.35`](https://togithub.com/99designs/gqlgen/blob/HEAD/CHANGELOG.md#v01735---2023-07-15) [Compare Source](https://togithub.com/99designs/gqlgen/compare/v0.17.34...v0.17.35) - <a href="https://togithub.com/99designs/gqlgen/commit/05006bf1dcb9451b0960d07fd68370145c2697b4"><tt>[`05006bf`](https://togithub.com/99designs/gqlgen/commit/05006bf1)</tt></a> release v0.17.35 - <a href="https://togithub.com/99designs/gqlgen/commit/d95d614f8fc2c5983390adf0507027a1efdd778a"><tt>[`d95d614`](https://togithub.com/99designs/gqlgen/commit/d95d614f)</tt></a> Update gqlparser to v2.5.7 (<a href="https://togithub.com/99designs/gqlgen/pull/2714">[#​2714](https://togithub.com/99designs/gqlgen/issues/2714)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/8c378e6bdd1962822216053ae2c01e89ef35034a"><tt>[`8c378e6`](https://togithub.com/99designs/gqlgen/commit/8c378e6b)</tt></a> Updated GraphiQL playground 2.0.7 -> 3.0.1 and react 17 -> 18 (<a href="https://togithub.com/99designs/gqlgen/pull/2713">[#​2713](https://togithub.com/99designs/gqlgen/issues/2713)</a>) <dl><dd><details><summary><a href="https://togithub.com/99designs/gqlgen/commit/7880739d48a9aa2d6f4be87129cb361d2c2c0345"><tt>7880739d</tt></a> Add op ctx safety for apollo tracing (<a href="https://togithub.com/99designs/gqlgen/pull/2709">#​2709</a>)</summary> - Add automated tests for both tracing and tracer to simulate a client disconnect - Check for existence of operation context before proceeding to avoid panic </details></dd></dl> - <a href="https://togithub.com/99designs/gqlgen/commit/6ed9337bce0daf05c1c3bda29fd86368768cdb68"><tt>[`6ed9337`](https://togithub.com/99designs/gqlgen/commit/6ed9337b)</tt></a> fix function name in comment (<a href="https://togithub.com/99designs/gqlgen/pull/2707">[#​2707](https://togithub.com/99designs/gqlgen/issues/2707)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/2cfb9f98c4c2b090a6a65816ed28a67501303768"><tt>[`2cfb9f9`](https://togithub.com/99designs/gqlgen/commit/2cfb9f98)</tt></a> Fix apollo integrity hash (<a href="https://togithub.com/99designs/gqlgen/pull/2706">[#​2706](https://togithub.com/99designs/gqlgen/issues/2706)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/470fca87d3002399fb02e14cf014c3c26755d87b"><tt>[`470fca8`](https://togithub.com/99designs/gqlgen/commit/470fca87)</tt></a> Update gqlparser again (<a href="https://togithub.com/99designs/gqlgen/pull/2697">[#​2697](https://togithub.com/99designs/gqlgen/issues/2697)</a>) - <a href="https://togithub.com/99designs/gqlgen/commit/280441b1a0c46652f3b16692839fbdbd024aa06d"><tt>[`280441b`](https://togithub.com/99designs/gqlgen/commit/280441b1)</tt></a> Update changelog - <a href="https://togithub.com/99designs/gqlgen/commit/5bc36e142dfffceb96ac8b23bb9c13b492504474"><tt>[`5bc36e1`](https://togithub.com/99designs/gqlgen/commit/5bc36e14)</tt></a> v0.17.34 postrelease bump <!-- end of Commits --> <!-- end of Else --> <!-- end of If NoteGroups --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/infratographer/x). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi4yNC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous code #2720 introduced a bug when setting the package variable of
resolverTemplate. I tested the code changes and noticed that subsequent runs would still use the template even if not set.We need to make a copy of the template so that subsequent calls don't use the same template as the previous run. 😓