Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the deprecated function of go-keyring #56

Open
SgtDaJim opened this issue Nov 11, 2019 · 5 comments
Open

Using the deprecated function of go-keyring #56

SgtDaJim opened this issue Nov 11, 2019 · 5 comments

Comments

@SgtDaJim
Copy link

When I built my cli app, a warning occured:

# github.com/keybase/go-keychain
cgo-gcc-prolog:202:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

Maybe the package should be updated?
@osok
Copy link

osok commented Dec 10, 2019

I'm having the same issue on one of my developers boxes. They just upgraded to Catalina. I'm using High Sierra and it works fine.

@mtibben
Copy link
Member

mtibben commented Dec 16, 2019

in your go.mod use

replace github.com/keybase/go-keychain => github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4

@kyoh86 kyoh86 mentioned this issue Jan 1, 2020
Closed
@n11c
Copy link

n11c commented Jan 3, 2020

It looks like keybase/go-keychain addressed the issue by removing that bit of code altogether: keybase/go-keychain@378d9d7

I did a quick and dirty test and it works fine for me: https://github.com/n11c/keyring/tree/fix-catalina-deprecation

Happy to clean it up and make a PR if you feel this is the way to go.

@kyoh86 kyoh86 mentioned this issue Jan 5, 2020
Closed
@santiagocanti
Copy link

@n11c if you could send the PR it would be great! Otherwise let me know and I can take a crack at it :D

@n11c n11c mentioned this issue Jan 17, 2020
Closed
@n11c
Copy link

n11c commented Jan 17, 2020

@santiagocanti done :)

@jonioni jonioni mentioned this issue Mar 12, 2020
Open
@ggutoski ggutoski mentioned this issue Oct 8, 2020
Closed
pda added a commit to buildkite/cli that referenced this issue Dec 3, 2020
@pda
Update 99designs/keyring & replace keybase/go-keychain for macOS fix
cbee63f 
Otherwise the build fails on macOS 11 Big Sur with:

\# github.com/keybase/go-keychain
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

See also:
99designs/keyring#56 (comment)
99designs/keyring#66
keybase/go-keychain#55
99designs/aws-vault#427
@pda pda mentioned this issue Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependent modules
Fix deprecated TrustedApplicationAccess on Macos Catalina n11c/keyring
5 participants
@mtibben @osok @n11c @SgtDaJim @santiagocanti