Update go-keychain dependency to latest

[hraban]

Fixes build errors on my Mac (10.13.3).

MacBook-Pro:keyring hraban$ go build
# github.com/99designs/keyring/vendor/github.com/keybase/go-keychain
vendor/github.com/keybase/go-keychain/corefoundation.go:29: cannot use nil as type _Ctype_CFDataRef in return argument
vendor/github.com/keybase/go-keychain/corefoundation.go:36: cannot convert nil to type _Ctype_CFDataRef
vendor/github.com/keybase/go-keychain/corefoundation.go:37: cannot use nil as type _Ctype_CFDataRef in return argument
vendor/github.com/keybase/go-keychain/corefoundation.go:62: cannot convert nil to type _Ctype_CFDictionaryRef
vendor/github.com/keybase/go-keychain/corefoundation.go:63: cannot use nil as type _Ctype_CFDictionaryRef in return argument
vendor/github.com/keybase/go-keychain/corefoundation.go:74: cannot convert &keys[0] (type *_Ctype_CFTypeRef) to type *unsafe.Pointer
vendor/github.com/keybase/go-keychain/corefoundation.go:74: cannot convert &values[0] (type *_Ctype_CFTypeRef) to type *unsafe.Pointer
vendor/github.com/keybase/go-keychain/corefoundation.go:87: cannot use nil as type _Ctype_CFStringRef in return argument
vendor/github.com/keybase/go-keychain/corefoundation.go:90: cannot use nil as type _Ctype_CFStringRef in return argument
vendor/github.com/keybase/go-keychain/corefoundation.go:141: cannot convert &a[0] (type *_Ctype_CFTypeRef) to type *unsafe.Pointer
vendor/github.com/keybase/go-keychain/corefoundation.go:141: too many errors

I'm not sure why this is, but manually updating go-keychain solved the problem so I just left it at that.

[hraban]

I'm getting similar build errors on aws-vault but those seem less straight-forward to solve :( any ideas? Backstory: I'm working on a 1 password backend.

[dfuentes]

The original build errors were because of a breaking change in go1.10 w.r.t. cgo code (keybase/go-keychain#25). I'm running into this as well for a project that pulls uses this one.

[hraban]

so I'm imagining my PR, as-is, breaks compat with go ≤1.9 ?

I've been out of the go loop for a while, but why did they make a backwards incompatible change in a minor? >.<

[dfuentes]

Nope, your PR is fine. The change was backwards incompatible, but by using build constraints, go-keychain was able to retain compatibility with both older go versions and newer ones.

[hraban]

Ah, great. But this might be harder on aws-vault, then, if I understand it correctly ?

…

On 15 Mar 2018, at 19:03, Daniel Fuentes ***@***.***> wrote: Nope, your PR is fine. The change was backwards incompatible, but by using build constraints, go-keychain was able to retain compatibility with both older go versions and newer ones. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.