Percent-encode filenames with slash #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtibben
force-pushed
the
percent-encode-slash
branch
from
ed0b00f
to
b39a68d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the keyring file backend is extremely permissive, as the filename is used as the key without any kind of escaping.
This PR does the bare-minimum by escaping
/which I understand is the only character not allowed by unix systems. I'm really not sure how Windows handles this, so will leave further escaping for someone more familiar with Windows filesystems.I don't anticipate major backwards-compatibility issues, as using a
/character was failing already. The only edge-case is if anyone has used a%character in a key, this may need to be manually migrated.