Fixes for 2 memory-leaks #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ReneLergner. Thanks for your contribution. I have merged this on master. |
|
Thanks. This is the tool where I use Capstone.NET: https://github.com/ReneLergner/Patcher. More info here: https://wpinternals.net/index.php/135-new-versions-of-wpinternals-and-autopatcher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 9ee1. Thanks for creating this project. I'm using it in a new project, which I will push to Github soon. While using your project I found 2 memory-leaks. I fixed them in my fork. Feel free to pull them to your branch.
The first memory-leak happens in CapstoneDisassembler.Disassemble() because the ownership of an disposable object is passed to this function. The object should then be disposed in this function.
The second memory-leak happens in CapstoneDisassembler.MoveNext(). It gets unmanaged data, which needs to be freed.