Skip to content

Conversation

adamsitnik
Copy link
Contributor

Steps I took:

  1. Cloned v4 branch
  2. Updated it to lastest VS (it uses 2010 by default)
  3. Added arm64 target
  4. Built it Release for arm64, copied the produced capstone.dll
  5. Created a new nuget package version locally by using dotnet pack
  6. Created a test console app with new nuget.config file pointing to the folder with the package
  7. Run the app on .NET 7 Windows 11 arm64 and ensured that it works.

cc @janvorli

@9ee1
Copy link
Owner

9ee1 commented Oct 1, 2022

Hello. Thank you very much for your contribution.

It looks like the v4 branch has additional commits then the 4.0.2 tag, the latter of which is marked as the latest release. I know it is mentioned in #32 the binaries were compiled for 4.0.2, but I am not sure which branch/tag on the Capstone repository they were compiled from. I have not taken a look at the diff so I am not sure it would make a difference but it might be prudent to have all the packaged binaries built from the same source.

@js6pak, can you please confirm if you used the v4 branch or the 4.0.2 tag in #32? If it is the latter, @adamsitnik, would you mind rebuilding the binary in this PR from the 4.0.2 tag?

@js6pak
Copy link
Contributor

js6pak commented Oct 1, 2022

My binaries were from the 4.0.2 tag not the branch, yes

@adamsitnik
Copy link
Contributor Author

@9ee1 Good point! I've updated the PR and provided version built from 4.0.2 tag. Thanks!

@9ee1 9ee1 changed the title add native capstone.dll for Windows arm64 (build from v4 branch) Add Capstone ARM64 Binary Oct 3, 2022
@9ee1 9ee1 added this to the Capstone.NET 2.2.0 milestone Oct 3, 2022
@9ee1
Copy link
Owner

9ee1 commented Oct 3, 2022

Thank you @js6pak and @adamsitnik.

@9ee1 9ee1 merged commit 60189a5 into 9ee1:master Oct 3, 2022
@9ee1 9ee1 changed the title Add Capstone ARM64 Binary Add Capstone Windows ARM64 Binary Oct 3, 2022
@9ee1 9ee1 changed the title Add Capstone Windows ARM64 Binary Add Capstone ARM64 Binary Oct 3, 2022
@adamsitnik adamsitnik deleted the windowsArm branch October 4, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants