Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all cleverness that broke uploads #234

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

9seconds
Copy link
Owner

@9seconds 9seconds commented Dec 3, 2021

This fixes #233

I have removed syncPairs and fancy tricks that bufferize writes simulating TCP_CORK. They allow to achieve better performance but break uploads. This was unexpected but it seems that this part of the protocol is quite sensitive to timings. This hotfix PR removes a cleverness

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #234 (93bed24) into master (219235e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   82.56%   82.60%   +0.04%     
==========================================
  Files          69       68       -1     
  Lines        1927     1897      -30     
==========================================
- Hits         1591     1567      -24     
+ Misses        236      232       -4     
+ Partials      100       98       -2     
Impacted Files Coverage Δ
mtglib/internal/relay/pools.go 100.00% <100.00%> (ø)
mtglib/internal/relay/relay.go 92.85% <100.00%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 219235e...93bed24. Read the comment docs.

@9seconds 9seconds merged commit 2f626e2 into master Dec 3, 2021
@9seconds 9seconds deleted the cant-send-attachment branch December 3, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.1.3 version cannot send attachment
2 participants