Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call callback only once (even on error) #47

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

maxkoryukov
Copy link
Contributor

@maxkoryukov maxkoryukov commented Jan 25, 2017

@coveralls
Copy link

coveralls commented Jan 25, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7b6ea37 on maxkoryukov:fix/callback-doublecall into e95095d on A:master.

@tbranyen
Copy link
Collaborator

Looks good to me!

@tbranyen tbranyen merged commit 6ff0027 into A:master Jan 26, 2017
@tbranyen
Copy link
Collaborator

Thanks for the fix @maxkoryukov

@maxkoryukov
Copy link
Contributor Author

@tbranyen , plz, tell me, when the package on NPM will be updated? I want to switch from git-dependency to NPM-dep (you know - it is much more convenient)

@tbranyen
Copy link
Collaborator

I understand, I'll try and push it out tomorrow.

@maxkoryukov
Copy link
Contributor Author

@tbranyen , NPM still keeping 0.5.2... 😢

@maxkoryukov
Copy link
Contributor Author

@tbranyen , LOOK MA)) still 0.5.2 👐

@maxkoryukov maxkoryukov deleted the fix/callback-doublecall branch February 4, 2017 17:02
@maxkoryukov
Copy link
Contributor Author

Hello 🚶‍♂️ Are there anybody out there;) @tbranyen , plz upgrade NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double call callback
3 participants