Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the name of HTTP method to mocking callback #48

Closed
wants to merge 2 commits into from
Closed

Pass the name of HTTP method to mocking callback #48

wants to merge 2 commits into from

Conversation

maxkoryukov
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9483b79 on maxkoryukov:feature/method-in-req into e95095d on A:master.

@coveralls
Copy link

coveralls commented Jan 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9d59332 on maxkoryukov:feature/method-in-req into e95095d on A:master.

@tbranyen
Copy link
Collaborator

No unit test for this? How is it used?

@maxkoryukov
Copy link
Contributor Author

@tbranyen , you are right, no need to include this into upstream. I have a very convenient mocks function for this;)
Just publish 0.5.3 on npm, please, we are wating...

@maxkoryukov maxkoryukov closed this Feb 2, 2017
@maxkoryukov maxkoryukov deleted the feature/method-in-req branch February 2, 2017 10:07
@A
Copy link
Owner

A commented Feb 11, 2017

Sorry guys, I just missed status of the PR)

@maxkoryukov
Copy link
Contributor Author

I have revoked this PR - this amendments are useful only for my old approach, not for everyone..

@A, plz, better look at #47 - it is already merged, but the latest NPM version is 0.5.2 - without fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxkoryukov @coveralls @tbranyen @A