Save allow flight as snapshot data & run commands with a delay #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… /give commands not being affected by inv clear)
A5H73Y
requested changes
Sep 13, 2023
| @@ -557,6 +557,7 @@ public void finishCourse(final Player player) { | |||
| playerConfig.resetPlayerDataSnapshot(); | |||
| playerConfig.resetSessionJoinLocation(); | |||
| playerConfig.resetSessionData(); | |||
| rewardPrize(player, session); | |||
There was a problem hiding this comment.
I dont think I tested without that change. I just wanted commands like /item working
| .filter(ValidationUtils::isStringValid) | ||
| .forEach(command -> PlayerUtils.dispatchServerPlayerCommand(command, player, session)); | ||
| } | ||
| }.runTaskLater(parkour, 2L); |
There was a problem hiding this comment.
If we are doing this, I'd prefer to make it configurable - 0 by default
There was a problem hiding this comment.
Want me to impl that? Im on GH mobile so idk if you suggested changes or anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.