Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Asheron's Benediction #1615

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

gmriggs
Copy link
Collaborator

@gmriggs gmriggs commented Mar 31, 2019

This adds support for vital multiplier enchantments, such as Asheron's Benediction

For adding and removing enchantments which affect MaxVitals, an UpdateVital packet is also now sent much quicker, instead of on the next VitalTick update

This resolves #1607

@Warloxx01
Copy link

Warloxx01 commented Mar 31, 2019

I applied this update and all went well till I went into combat in Metos (First try at combat after application of update) I noticed that I was not hitting anything and when I looked at the server window I saw this...
Error.txt
Im relatively certain I applied this corretley. It appears the spell hits the target the first time then never hit the target again.

@gmriggs
Copy link
Collaborator Author

gmriggs commented Mar 31, 2019

@Warloxx01

The bug you are seeing unfortunately snuck into #1611

The fix has been posted in #1616

Thanks for helping to test everything!

@gmriggs gmriggs merged commit 3cae69b into ACEmulator:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asheron's Lesser Benediction spell doesn't fully work
3 participants