Support for specific server host binding #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LtRipley36706
approved these changes
Mar 22, 2017
Source/ACE/Config.json.example
Outdated
| "Port": 9000 | ||
| }, | ||
| "Network": { | ||
| "Host": "127.0.0.1", |
There was a problem hiding this comment.
Nitpickmode: kill the extra space here to make line "Host": "127.0.0.1",
Source/ACE/Config.json.example
Outdated
| @@ -3,7 +3,7 @@ | |||
| "WorldName": "ACEmulator", | |||
| "Welcome": "Welcome to this ACE server!\nFor more information visit http://www.acemulator.org.", | |||
| "Network": { | |||
| "Host": "127.0.0.1", | |||
| "Host": "127.0.0.1", | |||
There was a problem hiding this comment.
upon further thought, change this to "Host": "0.0.0.0",
That way, we're basically set to IPAddress.Any by default, then the server op can change it to be more specific.
as is, the default of 127.0.0.1 means the server is only gonna listen for local loopback
|
Now, really, all good here 👍 |
Mag-nus
reviewed
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.