Fix issue with gems casting recall spells #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmriggs
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
tested with packet crafting to ensure player cannot cast a portal spell w/ another player as the target, along with any other self-spells...
the result was blue message in chat box 'Target is out of range!', due to most self-spells having near-0 range in their spell data.
so this part looks good, however to make this completely correct, eventually spells should be checking their bitflags for the 'self target' bit, and ensuring target==self if that is the only valid target, and sending 'Invalid target' werror
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.