Update Healer.cs #2033
Merged
Update Healer.cs #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the healing target's attribute is at max, without assuming it's always health. Covers the rare, gauntlet, and casino Stamina/Mana kits.
|
Thanks for the PR Someone mentioned that stamina / mana healing kits weren't working yet (these types of healing kits for other vitals were news to me), and I was going to investigate these soon I will playtest this PR for these items |
|
ah i see some preliminary work for adding other vital types was in there, but the initial check was still always for Health This looks like a good change, and is moving in the right direction for all of the different healing kits types. I noticed a few other details for stamina/mana/unlimited use kits, mostly related to messages sent to the player. I can help clean these other messages up after this PR, unless anyone else would like to do that part Looks good to me, thanks again |
gmriggs
approved these changes
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the healing target's attribute is at max, without assuming it's always health. Covers the rare, gauntlet, and casino Stamina/Mana kits.