Added configurable 'player_save_interval' seconds property #2146
Conversation
| @@ -27,11 +27,18 @@ public static class PlayerManager | |||
| private static readonly Dictionary<uint, Player> onlinePlayers = new Dictionary<uint, Player>(); | |||
| private static readonly Dictionary<uint, OfflinePlayer> offlinePlayers = new Dictionary<uint, OfflinePlayer>(); | |||
|
|
|||
| public static readonly long DefaultPlayerSaveInterval = 5; | |||
There was a problem hiding this comment.
When I was thinking about this, I was thinking the unit of measurement would be seconds.
There was a problem hiding this comment.
I'll add a suffix indicating it's seconds.
| @@ -47,6 +47,11 @@ public partial class Player : Creature, IPlayer | |||
|
|
|||
| public float CurrentRadarRange => Location.Indoors ? 25.0f : 75.0f; | |||
|
|
|||
| public TimeSpan PlayerSaveInterval | |||
There was a problem hiding this comment.
This can go back in Player_Database.cs
There was a problem hiding this comment.
Woops. This isn't supposed to be in here anymore. Thanks for catching that.
There was a problem hiding this comment.
I remember what happened here. It says PlayerManager is not in scope for Player_Database
| // after becoming involved in a PK battle | ||
| ("player_save_interval", 5) // number of minutes between saving of characters |
There was a problem hiding this comment.
Seconds make sense here. It's the unit of measurement we use in the majority (all?) of cases in ACE
There was a problem hiding this comment.
I was just using the existing units which was minutes. Seconds works too. I'll switch it over.
dgarson
changed the title
|
Thanks for the seconds change. My only other thought is that PlayerManager should not be involved. I think you can just have PlayerSaveInterval in Player_Dabase.cs point to => PropertyManager.GetLong("player_save_interval", DefaultPlayerSaveIntervalSecs).Item; You can change PlayerSaveInterval to an int so you're not converting every request. If we want to capture changes from Propertymanager, it should raise an event that also includes the property being changed. Then, objects could subscribe to that event to determine if they need to make an adjustment. |
|
I found that PropertyManager was also inaccessible from Player_Database either. Any other ideas? I agree about the PropertyManager change callback but that felt outside the scope of this PR. |
|
Adding 'using ACE.Server.Managers;' should make PropertyManager "accessible" from Player_Database.cs. As far as I can see, the relevant API functions of PropertyManager are all set to public. |
…rom PropertyManager, bypassing need for any property update callbacks
|
@Mag-nus any more changes I should make to this PR before it's ready to merge? |
Adds a new configuration property for the number of minutes between the automatic save of player characters. This is in response to the the feature request in #1621