Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch BiotaPropertiesInt to Composite Key #2563

Merged
merged 7 commits into from
Jan 13, 2020

Conversation

Mag-nus
Copy link
Member

@Mag-nus Mag-nus commented Dec 22, 2019

To use ShardDatabaseWIthoutCaching (not recommended unless you really really need this due to EF tracking memory consumption issues)...

in DatabaseManager.cs
change this: var shardDb = new ShardDatabase();
to this: var shardDb = new ShardDatabaseWithoutCaching();

@Mag-nus
Copy link
Member Author

Mag-nus commented Dec 22, 2019

Maybe before this is merged into master, we should switch the other property tables to Composite key as well.

@gmriggs
Copy link
Collaborator

gmriggs commented Dec 22, 2019

testing on ce, looks good so far

@Mag-nus
Copy link
Member Author

Mag-nus commented Dec 26, 2019

#2569 should go in first.

LtRipley36706
LtRipley36706 previously approved these changes Dec 31, 2019
LtRipley36706
LtRipley36706 previously approved these changes Dec 31, 2019
@Mag-nus Mag-nus merged commit 446f2f1 into ACEmulator:master Jan 13, 2020
@Mag-nus Mag-nus deleted the BiotaPropertiesInt branch January 13, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants