Portal class changes #306
Closed
Portal class changes #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The societyId field in the new table structure is currently a placeholder that can be changed, if needed, for when Societies and their bound portals are implemented. |
fantoms
suggested changes
Apr 30, 2017
Source/ACE.Entity/AcePortalObject.cs
Outdated
| public byte SocietyId { get; set; } | ||
|
|
||
| [DbField("isTieable", (int)MySqlDbType.Bit)] | ||
| public bool IsTieable { get; set; } |
There was a problem hiding this comment.
Initially, I am getting a server crash for 'System.ArgumentException': Object of type 'System.Byte' cannot be converted to type 'System.Boolean', when I use a portal. This happens in Database.cs line the portal out of the database.
changelog.md
Outdated
| * !!! Please note that the ACE-World tables must be filled before importing the ace_portal_object's table / the Desert Mine sql | ||
| file contains an entry that is currently missing from the ACE-World DB release that also needs to be imported before the | ||
| ace_portal_object table is loaded. | ||
| * Implemented a portal recall debug command - An apparent bug was revealed that causes players on login to start at the last saved portal recall position |
There was a problem hiding this comment.
Bugs should also be reported in the Github issues section or noted in the bugged code section.
|
Couple comments:
|
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not combine base_ace_object, ace_object, ace_portal_object into one view at this juncture, as doing so would remove all portals that didn't have destinations set from the world, as the view would only show entries for portal objects that have data from all three tables present.
In the portal object table restructuring, I added a foreign key constraint to the weenieClassId field that points to that field in the ace_object table. This addition has the effect of not allowing the ace_portal_object table to be populated until the rest of the ace_world tables are filled. I also included a portal object that was missing from the ACE-World DB release that was preventing the ace_portal_object table data from being imported.
An apparent bug with the login position was revealed, when I added saving the PositionType.LastPortal position, when a portal was used. When a player logs in, the PositionType.LastPortal position gets used, rather than the one saved during the character save action.