Landblocks #309
Merged
Landblocks #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would keep it separated but you may need to see why the the ref issue is happening and if it all that ref is still needed. Logically I say cell data would not have any ref at all and would be ref by ace, and other classes. The circular ref occurres when the ace ref points to cell and the cell ref points to ace. That is poor ok code design so you got to make sure through proper project layout and code design that you only use the ref project as a ref project and not try to interconnect the too. Hope that helps a little |
Mogwai-TheFurry
approved these changes
May 1, 2017
| /// </summary> | ||
| namespace ACE.DatLoader.FileTypes | ||
| { | ||
| public class CellLandblock |
There was a problem hiding this comment.
"Landcell" would have been much preferred.
| /// Height 0-9 is Western most edge. 10-18 is S-to-N strip just to the East. And so on. | ||
| /// </summary> | ||
|
|
||
| // Places in the inland sea, for example, are false. Should denote presence of xxxxFFFE (where xxxx is the cell). |
There was a problem hiding this comment.
"xxxx" is the Landblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added client_cell.dat reading for Landblocks and proper z value for @Tele commands.
I attempted to add the client_cell.dat reading into the Position class itself, but this caused a cyclical reference. Not sure what the best way to address that is (or if there is even a need?)
Next step is to either complete the other sections of the client_cell.dat reading or to cache these. I don't like that it doesn't right now, since monsters & players & projectiles are going to generate an awful lot of file reads!