Weenie caching to fix portals #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the object factory, though I highly doubt i fixed the real issue.
ddevec
suggested changes
Jun 27, 2017
|
|
||
| public AceObject GetAceObjectByWeenie(uint weenieClassId) | ||
| { | ||
| if (!_weenieCache.ContainsKey(weenieClassId)) |
There was a problem hiding this comment.
This is most likely unsafe. Unless ContainsKey is guaranteed atomic w.r.t. _weenieCache (if Dictionaries are hash maps under the hood its highly unlikely), then this will eventually crash the code. Double-check locking relies on a strictly atomic and ordered pre-check (volatility guarantees ordering).
| public AceObject GetObject(uint aceObjectId) | ||
| { | ||
| // if they're asking for a weenie, just give them the weenie. | ||
| if (_weenieCache.ContainsKey(aceObjectId)) |
There was a problem hiding this comment.
Also unsafe, unless ContainsKey is atomic w.r.t. _weenieCache.
|
switched to a ConcurrentDictionary. blah. |
ddevec
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.