Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Preload #421

Merged
merged 8 commits into from
Jun 27, 2017
Merged

Master Preload #421

merged 8 commits into from
Jun 27, 2017

Conversation

Forbiddenz
Copy link
Contributor

Added ability to preload all the landblocks in the game.
This is a massive process, but its a great tool for testing or even benchmarking in the near future.

Copy link
Contributor

@Mogwai-TheFurry Mogwai-TheFurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the ability to force a landblock to load from the command line, however...

  1. Make it so that you can specify the landblock id. "loadLandblock X". The parameter is the ushort landblock id.
  2. To load them all, perhaps a separate command for "loadAllLandblocks". this needs to start a new thread or Task.
  3. Add a new function in LandblockManager that does the load, accepts the landblock Id, but does not return the block. For example:
public void PreLoadLandblock(LandblockId landblockId)
{
    GetLandblock(landdblockId, false);
}
  1. The new thread or task needs an interrupt mechanism so that it can be cancelled by a separate command or by the server shutdown command.

Stack, Writting code so bad that it forces Mogwai write code since early 2017.
@Forbiddenz
Copy link
Contributor Author

Made Changes.

@Mogwai-TheFurry Mogwai-TheFurry merged commit 5e29e0f into ACEmulator:master Jun 27, 2017
@Forbiddenz Forbiddenz deleted the GameWorldValidation branch October 12, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants